Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render HTML anchors for definition blocks #1191

Merged
merged 3 commits into from
Aug 3, 2022
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Aug 2, 2022

It's handy to be able to link to these.

Preview: https://pr1191--matrix-spec-previews.netlify.app

It's handy to be able to link to these.
@richvdh richvdh requested a review from a team as a code owner August 2, 2022 13:16
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog for this would be a good fit for #1194 😇

@richvdh richvdh merged commit dc4fd9b into main Aug 3, 2022
@richvdh richvdh deleted the rav/anchors_for_definitions branch August 3, 2022 06:28
richvdh added a commit that referenced this pull request Nov 15, 2022
Stick a `definition-` on the front of the autogenerated anchors for definition
blocks.

This solves a problem where, for example,
https://spec.matrix.org/unstable/application-service-api/#registration could
refer to either the "Registration" section or the `Registration` definition
therein.

(These anchors are relatively recent: they were added in #1191.
richvdh added a commit that referenced this pull request Nov 15, 2022
Stick a `definition-` on the front of the autogenerated anchors for definition
blocks.

This solves a problem where, for example,
https://spec.matrix.org/unstable/application-service-api/#registration could
refer to either the "Registration" section or the `Registration` definition
therein.

(These anchors are relatively recent: they were added in #1191.
clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
Stick a `definition-` on the front of the autogenerated anchors for definition
blocks.

This solves a problem where, for example,
https://spec.matrix.org/unstable/application-service-api/#registration could
refer to either the "Registration" section or the `Registration` definition
therein.

(These anchors are relatively recent: they were added in matrix-org#1191.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants