Generate unstable changelogs using towncrier #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
reviewed
Nov 15, 2022
richvdh
force-pushed
the
rav/cleaner_changelogs
branch
2 times, most recently
from
9e4306e
to
d64bed2
Compare
... which means we don't need to edit the top-level page for each release.
richvdh
force-pushed
the
rav/cleaner_changelogs
branch
from
eeaebd1
to
306bda3
Compare
richvdh
force-pushed
the
rav/cleaner_changelogs
branch
from
306bda3
to
1203ebe
Compare
turt2live
reviewed
Nov 15, 2022
| */}} | ||
|
|
||
| {{ with .Page.Resources.Match "*.md" }} | ||
| {{ range ((sort . "Name" "desc")) }} |
There was a problem hiding this comment.
will this cause a problem when we get to v1.10 or v10.0?
There was a problem hiding this comment.
I've fixed this by including the timestamp of when the changelog was generated in the file, and sorting by that instead.
Make sure we don't skip building the spec!
turt2live
approved these changes
Nov 15, 2022
I mean they are written three lines below in each changelog, but I'll take the thanks :) |
considering that's more effort than I put into reading the changelogs, thank you 😇 |
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
Replace the current stack of hugo templates with a towncrier invocation. The main advantage of this is that it means that the "Changes since last release" section is consistent with the changelogs for the actual releases. This also changes the release process so that the changelog is generated before tagging, which means that the thing tagged v1.5 is actually the v1.5 spec. Fixes matrix-org#908.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the current stack of hugo templates with a towncrier invocation. The main advantage of this is that it means that the "Changes since last release" section is consistent with the changelogs for the actual releases.
This also changes the release process so that the changelog is generated before tagging, which means that the thing tagged v1.5 is actually the v1.5 spec.
Fixes #908.
Suggest reviewing commit-by-commit.
Preview: https://pr1340--matrix-spec-previews.netlify.app