Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog is not collapsing entries #908

Closed
turt2live opened this issue Oct 14, 2021 · 1 comment · Fixed by #1340
Closed

Changelog is not collapsing entries #908

turt2live opened this issue Oct 14, 2021 · 1 comment · Fixed by #1340
Labels
A-Tools Related to the process and tools for building the spec

Comments

@turt2live
Copy link
Member

image
@turt2live turt2live mentioned this issue Feb 23, 2022
Closed
@richvdh
Copy link
Member

richvdh commented Feb 23, 2022

see for example https://spec.matrix.org/v1.2/changelog/#client-server-api.

per matrix-org/matrix-spec-proposals#3742:

Only affects rendered changelog when using the fragments. After generation (like v1.2 in unstable), it's working off of the towncrier output

Oh, so this is kinda related to #955, where it would be nice to generate the changelog, then tag. (If we fixed #955, this problem would only affect the unstable spec, which would be less of a problem.)

@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 2, 2022
@turt2live turt2live added the A-Tools Related to the process and tools for building the spec label May 28, 2022
@richvdh richvdh mentioned this issue Nov 15, 2022
Merged
richvdh added a commit that referenced this issue Nov 15, 2022
@richvdh
Generate unstable changelogs using towncrier (#1340)
08fde5f 
Replace the current stack of hugo templates with a towncrier invocation. The main advantage of this is that it means that the "Changes since last release" section is consistent with the changelogs for the actual releases.

This also changes the release process so that the changelog is generated before tagging, which means that the thing tagged v1.5 is actually the v1.5 spec.

Fixes #908.
clokep pushed a commit to clokep/matrix-spec that referenced this issue May 3, 2023
@richvdh @clokep
Generate unstable changelogs using towncrier (matrix-org#1340)
77628fb 
Replace the current stack of hugo templates with a towncrier invocation. The main advantage of this is that it means that the "Changes since last release" section is consistent with the changelogs for the actual releases.

This also changes the release process so that the changelog is generated before tagging, which means that the thing tagged v1.5 is actually the v1.5 spec.

Fixes matrix-org#908.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Tools Related to the process and tools for building the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate unstable changelogs using towncrier matrix-org/matrix-spec
2 participants
@turt2live @richvdh