Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard error responses (MSC3743). #1347

Merged
merged 6 commits into from Nov 22, 2022

Conversation

clokep
Copy link
Contributor

@clokep clokep commented Nov 17, 2022

Spec PR for matrix-org/matrix-spec-proposals#3743.

I wasn't sure if there was a single spot I should put this or if we should just put it into each separate bit of the spec. I chose the latter since there didn't seem to be a good consolidated spot.

This isn't quite as clear as I'd like it to be (as it should apply to everything under /_matrix).

Preview: https://pr1347--matrix-spec-previews.netlify.app

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me on the whole! I think the place you chose to put the information in each spec is appropriate.

Just some small fixes below, nothing major.

content/application-service-api.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/application-service-api.md Outdated Show resolved Hide resolved
content/application-service-api.md Outdated Show resolved Hide resolved
content/identity-service-api.md Outdated Show resolved Hide resolved
clokep and others added 4 commits November 22, 2022 10:41
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@anoadragon453 anoadragon453 merged commit eeb4304 into matrix-org:main Nov 22, 2022
@clokep clokep deleted the std-err-resp branch November 22, 2022 15:55
clokep added a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants