server-server YAML files are not valid

[afranke]

Running node validator.js on each of the files in data/api/server-server reveals errors in the following ones:

• invites-v1.yaml
• invites-v2.yaml
• joins-v1.yaml
• joins-v2.yaml
• keys_query.yaml
• keys_server.yaml
• knocks.yaml
• leaving-v1.yaml
• leaving-v2.yaml
• third_party_invite.yaml
• transactions.yaml
• user_keys.yaml

I haven’t taken the time to look into the files in the definitions/ subdirectory, that should be checked too.

This is blocking publication (via CI) of the server-server OpenAPI JSON.

[zecakeh]

These files now pass validation, since they have been fixed before changing the validator in CI to Redocly-CLI.

Does that mean that the OpenAPI server-server definition should be generated in CI now?

[richvdh]

Interesting. Yes it should, but it currently is not:

matrix-spec/.github/workflows/main.yml

Lines 95 to 109 in a147b97

	scripts/dump-openapi.py \
	--base-url "https://spec.matrix.org${{ needs.calculate-baseurl.outputs.baseURL }}" \
	--api application-service \
	-r "$RELEASE" \
	-o spec/application-service-api/api.json
	scripts/dump-openapi.py \
	--base-url "https://spec.matrix.org${{ needs.calculate-baseurl.outputs.baseURL }}" \
	--api client-server \
	-r "$RELEASE" \
	-o spec/client-server-api/api.json
	scripts/dump-openapi.py \
	--base-url "https://spec.matrix.org${{ needs.calculate-baseurl.outputs.baseURL }}" \
	--api push-gateway \
	-r "$RELEASE" \
	-o spec/push-gateway-api/api.json

[richvdh]

closing in favour of #1649