Improve formatting of definitions in the Push Notifications section #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
uhoreg
requested changes
Jan 26, 2023
There was a problem hiding this comment.
Good catch. Looks like this was originally a definition list, but it got lost in the conversion. Could you try switching it use the Markdown definition list markup. There's an example a bit later, under the Push Rules > Actions section (line ~190 of push.md).
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
HarHarLinks
changed the title
uhoreg
approved these changes
Jan 29, 2023
|
Thanks! |
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
…atrix-org#1415) Signed-off-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kim Brose 2803622+HarHarLinks@users.noreply.github.com
I thought I skipped a beat when I tried to read this https://spec.matrix.org/unstable/client-server-api/#push-notifications:
The same idea might apply to the rest of the spec, but I don't have time to search for it.
Preview: https://pr1415--matrix-spec-previews.netlify.app