Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spelling in s2s authorization #1431

Conversation

saiprakash2
Copy link
Contributor

@saiprakash2 saiprakash2 commented Feb 12, 2023

Fixes #1231

@saiprakash2 saiprakash2 requested a review from a team as a code owner February 12, 2023 15:14
@turt2live turt2live changed the title Issue #1231/Update spelling in s2s authorization Update spelling in s2s authorization Feb 13, 2023
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I've already fixed the PR title and description, but please review https://github.com/matrix-org/matrix-spec/blob/main/CONTRIBUTING.rst when you get a chance.

Primarily, this needs a changelog entry to cover the typo.

@saiprakash2
Copy link
Contributor Author

I added the change log entry.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turt2live turt2live enabled auto-merge (squash) February 15, 2023 21:07
@turt2live turt2live merged commit ea47197 into matrix-org:main Feb 15, 2023
clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
* Issue matrix-org#1231/Update spelling in s2s authorization

* Update spelling in s2s authorization.

* Apply suggestions from code review

---------

Co-authored-by: Travis Ralston <travpc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spelling: s2s authorization header says 'receiving sender' instead of 'receiving server'
2 participants