Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification to transaction identifier idempotent semantics #1449

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

hughns
Copy link
Member

@hughns hughns commented Feb 23, 2023

The Client-Server API currently describes requests as being "idempotent" in the transaction identifier section:

The client-server API typically uses HTTP PUT to submit requests with a client-generated transaction identifier. This means that these requests are idempotent.

However, there is no definition of what the expected idempotency semantics are.

I've attempted to clarify what I believe are the intended semantics.

I've also added a complement test for this behaviour: matrix-org/complement#622

Preview: https://pr1449--matrix-spec-previews.netlify.app

@hughns hughns marked this pull request as ready for review February 23, 2023 12:14
@hughns hughns requested a review from a team as a code owner February 23, 2023 12:14
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@richvdh richvdh merged commit 10844fe into matrix-org:main Mar 7, 2023
@hughns hughns deleted the hughns/txnid-clarification branch March 31, 2023 15:05
clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants