Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for transaction ID semantics #622

Merged
merged 7 commits into from Apr 13, 2023
Merged

Tests for transaction ID semantics #622

merged 7 commits into from Apr 13, 2023

Conversation

hughns
Copy link
Member

@hughns hughns commented Mar 4, 2023 •
edited

This adds Client-Server API tests relation to transaction identifiers:

  1. That requests are idempotent within a single client session
  2. That transaction ID can be re-used across client sessions
  3. That the transaction ID is present in /sync response to deal with "local echo"

Signed-off-by: Hugh Nimmo-Smith hughns@element.io

@hughns hughns force-pushed the hughns/txnid-semantics branch 2 times, most recently from 16054c8 to 49d0556 Compare March 4, 2023 08:57
@hughns hughns marked this pull request as ready for review March 4, 2023 23:20
@hughns hughns requested review from a team and kegsay as code owners March 4, 2023 23:20
@hughns hughns changed the title Test for transaction ID semantics Tests for transaction ID semantics Mar 4, 2023
@hughns hughns mentioned this pull request Mar 4, 2023
Closed
kegsay
kegsay requested changes Mar 6, 2023
View reviewed changes
internal/client/client.go Show resolved Hide resolved
tests/csapi/txnid_test.go Show resolved Hide resolved
tests/csapi/txnid_test.go Outdated Show resolved Hide resolved
tests/csapi/txnid_test.go Outdated Show resolved Hide resolved
internal/client/client.go Outdated Show resolved Hide resolved
hughns and others added 2 commits March 6, 2023 19:17
@hughns hughns requested a review from kegsay March 9, 2023 18:03
@hughns hughns mentioned this pull request Mar 23, 2023
Merged
@DMRobertson DMRobertson mentioned this pull request Mar 23, 2023
Closed
@sandhose sandhose mentioned this pull request Mar 24, 2023
Closed
DMRobertson
DMRobertson reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the error messages I pointed out, I think I only have questions and comments rather than hard changes:

internal/client/client.go Outdated Show resolved Hide resolved
internal/client/client.go Outdated Show resolved Hide resolved
tests/csapi/txnid_test.go Show resolved Hide resolved
tests/csapi/txnid_test.go Outdated Show resolved Hide resolved
tests/csapi/txnid_test.go Outdated Show resolved Hide resolved
tests/csapi/txnid_test.go Show resolved Hide resolved
hughns and others added 2 commits April 12, 2023 09:55
@hughns @DMRobertson
Apply suggestions from code review
3518f63 
Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
@hughns
Incorporate review feedback
e87ba7d
@hughns hughns requested a review from DMRobertson April 13, 2023 17:38
DMRobertson
DMRobertson approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI is happy!

@DMRobertson DMRobertson merged commit 9f43aa2 into matrix-org:main Apr 13, 2023
3 of 4 checks passed
@hughns hughns deleted the hughns/txnid-semantics branch April 18, 2023 17:12
@hughns hughns mentioned this pull request Apr 18, 2023
Merged
hughns added a commit to sandhose/complement that referenced this pull request Apr 18, 2023
@hughns @kegsay @DMRobertson
Tests for transaction ID semantics (matrix-org#622)
added55 
* Test for transaction ID semantics

* Update internal/client/client.go

Co-authored-by: kegsay <kegsay@gmail.com>

* Incorporate review feedback

* Refactor for legibility

* Clarify that conduit doesn't pass idempotency tests

* Apply suggestions from code review

Co-authored-by: David Robertson <david.m.robertson1@gmail.com>

* Incorporate review feedback

---------

Co-authored-by: kegsay <kegsay@gmail.com>
Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
@clokep clokep mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

@kegsay kegsay Awaiting requested review from kegsay kegsay is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hughns @kegsay @DMRobertson