Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to edit a relation onto an existing event #1452

Open
MadLittleMods opened this issue Feb 23, 2023 · 3 comments
Open

Add support to edit a relation onto an existing event #1452

MadLittleMods opened this issue Feb 23, 2023 · 3 comments
Labels
improvement An idea/future MSC for the spec

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Feb 23, 2023

Use case

When you forget to "reply" to a specific message it would be useful to edit the message and attach the reply.

See element-hq/element-meta#1047 for ideas/interest in this feature in Element.

Proposal

Nothing needs to change spec-wise except for the language to allow it (as far as I know).

This already technically works in Synapse/Element after matrix-org/matrix-react-sdk#6817


Related to retroactive threading

Prior art

MSC2676 already explicitly calls out that this is not allowed:

There was some discussion on the MSC to allow for this but it was punted to a future proposal

@clokep
Copy link
Member

clokep commented Feb 24, 2023

This already technically works in Synapse/Element after matrix-org/matrix-react-sdk#6817

You're very much not supposed to be able to edit relations and I'm fairly sure that Synapse does not take them into account. In particular, does the /relations API or the aggregation include the new relation afterward? I suspect this is a client bug of some sort where it doesn't properly use the original m.relates_to property of the event.

@t3chguy
Copy link
Member

t3chguy commented Feb 27, 2023

https://spec.matrix.org/v1.6/client-server-api/#applying-mnew_content

Any m.relates_to property within m.new_content is ignored.

@t3chguy
Copy link
Member

t3chguy commented Feb 27, 2023

matrix-org/matrix-js-sdk#3178 aligns Element Web with Spec & Synapse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An idea/future MSC for the spec
Projects
None yet
Development

No branches or pull requests

3 participants