Define how clients process push rules #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
force-pushed
the
clokep/push-rework
branch
from
70dabf6
to
371d70d
Compare
clokep
commented
Mar 14, 2023
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
|
Thanks for the review! I think this is ready for another look! 👍 |
richvdh
approved these changes
Mar 14, 2023
47 tasks
clokep
added a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
* Move Push Rules section out from Client Behaviour. * Clarify server vs. client behavior. * Remove references to unencrypted content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1401: I'm not 100% sure this is accurate, but I think it is? It doesn't answer all the questions in that issue, but gets a lot closer.
Based on #1441.Preview: https://pr1461--matrix-spec-previews.netlify.app