Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrections to the response format of /_matrix/identity/v2/store-invite #1486

Merged
merged 2 commits into from May 3, 2023
Merged

Corrections to the response format of /_matrix/identity/v2/store-invite #1486

merged 2 commits into from May 3, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Apr 5, 2023 •
edited by github-actions bot

This has been wrong since the dawn of time.

Fixes #495

Preview: https://pr1486--matrix-spec-previews.netlify.app

@richvdh
Corrections to the response format of `/_matrix/identity/v2/store-inv…
5ad0db2 
…ite`

This has been wrong since the dawn of time.

Fixes #495
@richvdh richvdh requested a review from a team as a code owner April 5, 2023 15:30
@richvdh richvdh mentioned this pull request Apr 5, 2023
Closed
anoadragon453
anoadragon453 approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise. thanks!

data/api/identity/v2_store_invite.yaml Outdated Show resolved Hide resolved
changelogs/identity_service/newsfragments/1486.clarification Outdated Show resolved Hide resolved
@richvdh @anoadragon453
Apply suggestions from code review
20d9941 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@richvdh richvdh enabled auto-merge (squash) May 3, 2023 09:42
@richvdh richvdh merged commit 6150f71 into main May 3, 2023
10 checks passed
@richvdh richvdh deleted the rav/fix_store_invite_response branch May 3, 2023 09:43
@richvdh richvdh mentioned this pull request May 3, 2023
Open
This was referenced May 4, 2023
Merged
Closed
@S7evinK S7evinK mentioned this pull request Oct 2, 2023
Open
16 tasks
@matrixbot matrixbot mentioned this pull request Dec 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated "public_keys" section in response for /store-invite in the IS spec
2 participants
@richvdh @anoadragon453