Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated "public_keys" section in response for /store-invite in the IS spec #495

Closed
babolivier opened this issue Jul 6, 2019 · 3 comments · Fixed by #1486
Closed

Outdated "public_keys" section in response for /store-invite in the IS spec #495

babolivier opened this issue Jul 6, 2019 · 3 comments · Fixed by #1486
Labels
A-Identity-Service spec-bug Something which is in the spec, but is wrong

Comments

@babolivier
Copy link
Contributor

babolivier commented Jul 6, 2019

Since matrix-org/sydent#13, Sydent changed the responses it returns on /store-invite requests from

{
  "token": "sometoken",
  "public_keys": [
    "serverpublickey",
    "ephemeralpublickey"
  ],
  "display_name": "f...@b..."
}

to

{
  "token": "sometoken",
  "public_key": "serverpublickey",
  "public_keys": [
    {
      "public_key": "serverpublickey",
      "key_validity_url": "https://vector.im/_matrix/identity/api/v1/pubkey/isvalid"
    },
    {
      "public_key": "ephemeralpublickey",
      "key_validity_url": "https://vector.im/_matrix/identity/api/v1/pubkey/ephemeral/isvalid"
    },
  ],
  "display_name": "f...@b..."
}

Currently, the spec documents the former (and outdated) format: https://matrix.org/docs/spec/identity_service/latest#post-matrix-identity-api-v1-store-invite

@babolivier babolivier added the spec-omission implemented but not currently specified label Jul 6, 2019
@babolivier
Copy link
Contributor Author

Also the response example features a application/json top-level key, which doesn't exist in implementations.

@turt2live turt2live added A-Identity-Service spec-bug Something which is in the spec, but is wrong and removed spec-omission implemented but not currently specified labels Jul 6, 2019
@turt2live
Copy link
Member

The swagger is wrong, not omitted. The application/json part is because someone forgot the s at the end of examples on the response definition.

@richvdh
Copy link
Member

richvdh commented Apr 5, 2023

Fixed in #1486. Have filed matrix-org/sydent#561 to remove the unspecced public_key param in sydent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Identity-Service spec-bug Something which is in the spec, but is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants