Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

m.room.join_rules schema doesn't mention knock_restricted #1491

Closed
turt2live opened this issue Apr 12, 2023 · 0 comments · Fixed by #1535
Closed

m.room.join_rules schema doesn't mention knock_restricted #1491

turt2live opened this issue Apr 12, 2023 · 0 comments · Fixed by #1535
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit

Comments

@turt2live
Copy link
Member

Link to problem area: https://spec.matrix.org/v1.6/client-server-api/#mroomjoin_rules

Issue
The description lists it just fine, but the One of in the actual schema table has it omitted. This is almost certainly as easy as putting knock_restricted on the list in the yaml file.
@turt2live turt2live added the clarification An area where the expected behaviour is understood, but the spec could do with being more explicit label Apr 12, 2023
MichaelKohler added a commit to MichaelKohler/matrix-spec that referenced this issue May 23, 2023
@MichaelKohler
Add knock_restricted to m.room.join_rules enum
3fe228f 
Signed-off-by: Michael Kohler <me@michaelkohler.info>

Fixes matrix-org#1491
@MichaelKohler MichaelKohler mentioned this issue May 23, 2023
Merged
turt2live pushed a commit that referenced this issue May 23, 2023
@MichaelKohler
Add knock_restricted to m.room.join_rules enum (#1535)
c94bebc 
* Add knock_restricted to m.room.join_rules enum

Signed-off-by: Michael Kohler <me@michaelkohler.info>

Fixes #1491

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add knock_restricted to m.room.join_rules enum MichaelKohler/matrix-spec
1 participant
@turt2live