Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec for MSC2746 #1511

Merged
merged 38 commits into from May 23, 2023
Merged

Add spec for MSC2746 #1511

merged 38 commits into from May 23, 2023

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented May 4, 2023 •
edited by github-actions bot

dbkr added 17 commits May 2, 2023 16:54
@dbkr dbkr added the A-VoIP label May 4, 2023
@dbkr dbkr requested a review from a team as a code owner May 4, 2023 11:12
@turt2live turt2live mentioned this pull request May 16, 2023
Merged
@turt2live turt2live added the release-blocker Blocks the next release from happening label May 16, 2023
uhoreg
uhoreg requested changes May 16, 2023
View reviewed changes
content/client-server-api/modules/voip_events.md Outdated Show resolved Hide resolved
content/client-server-api/modules/voip_events.md Outdated Show resolved Hide resolved
content/client-server-api/modules/voip_events.md Outdated Show resolved Hide resolved
content/client-server-api/modules/voip_events.md Outdated Show resolved Hide resolved
content/client-server-api/modules/voip_events.md Outdated Show resolved Hide resolved
data/event-schemas/schema/m.call.hangup.yaml Outdated
call_id:
type: string
description: The ID of the call this event relates to.
version:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be worthwhile to factor out the call_id, version, and party_id fields into a file that could be included in all the voip events. Maybe a core-event-schema/voip_event.yaml file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is neater. The only downside is that it repeats all the fields from a room event and I'm not sure how to make it not do that.

data/event-schemas/schema/m.call.invite.yaml Outdated Show resolved Hide resolved
data/event-schemas/schema/m.call.negotiate.yaml Outdated Show resolved Hide resolved
data/event-schemas/schema/m.call.negotiate.yaml Outdated Show resolved Hide resolved
data/event-schemas/schema/m.call.negotiate.yaml Outdated Show resolved Hide resolved
dbkr and others added 4 commits May 17, 2023 09:43
@dbkr @uhoreg
Change tense
1fda1ec 
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
@dbkr @uhoreg
Tense, typos & grammar
a6c2cf2 
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
@dbkr @uhoreg
Linkify
ea3cbec 
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
@dbkr @uhoreg
Remove unnecessary parts from link
70d7c36 
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
dbkr and others added 9 commits May 17, 2023 09:48
@dbkr @uhoreg
Capitalise
5b8e3ef 
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
@dbkr
Fix hangup reasons
1023399
@dbkr @uhoreg
Clarify who can answer
ea056a7 
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
@dbkr @uhoreg
Linkify
1855205 
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
@dbkr
Remove reference to 'this MSC'.
25ea0df
@dbkr
Move common VoIP fields into a call event type.
5d53d67
@dbkr
Move common voip events to the content, not the actual event
ffa0a6f
@dbkr
Remove reason from reject event
a5c9911 
I confused myself, but it's not in the MSC and it shouldn't be.
@dbkr
Failure to YAML
d1b4c72
@dbkr dbkr requested a review from uhoreg May 17, 2023 13:56
uhoreg
uhoreg approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo some suggestions

content/client-server-api/modules/voip_events.md Outdated Show resolved Hide resolved
data/event-schemas/schema/m.call.negotiate.yaml Show resolved Hide resolved
data/event-schemas/schema/m.call.hangup.yaml Show resolved Hide resolved
data/event-schemas/schema/m.call.invite.yaml Show resolved Hide resolved
data/event-schemas/schema/core-event-schema/call_event.yaml Show resolved Hide resolved
data/event-schemas/schema/m.call.reject.yaml Show resolved Hide resolved
data/event-schemas/schema/m.call.select_answer.yaml Show resolved Hide resolved
dbkr and others added 3 commits May 23, 2023 13:33
@dbkr @uhoreg
Fix number of room members allowed when sending voip events.
163605c 
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
@dbkr @uhoreg
Add 'added in' version
c6ae1a4 
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
@dbkr @uhoreg
Another added-in
d230788 
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
turt2live
turt2live reviewed May 23, 2023
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the build

data/event-schemas/schema/m.call.select_answer.yaml Outdated Show resolved Hide resolved
@turt2live
Copy link
Member

Looks like all threads are resolved here - merging.

@turt2live turt2live merged commit 4fd9f39 into main May 23, 2023
10 checks passed
@turt2live turt2live deleted the dbkr/2746-reliable-voip branch May 23, 2023 18:29
This was referenced May 24, 2023
Merged
Closed
Merged
Merged
Merged
@zecakeh zecakeh mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live left review comments

@uhoreg uhoreg uhoreg approved these changes

Assignees
No one assigned
Labels
A-VoIP release-blocker Blocks the next release from happening
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbkr @turt2live @uhoreg