Clarify that sdpMid and sdpMLineIndex are not required in m.call.candidates
#1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
…didates` MSC2746, merged in v1.17, introduced the end-of-candidates candidate, where only the `candidate` property is set to an empty string. Besides, the [WebRTC specification](https://www.w3.org/TR/webrtc/) says that only one of those fields is required in a normal candidate. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
zecakeh
changed the title
m.call.can… …didatesm.call.candidates
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
uhoreg
reviewed
Mar 7, 2024
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSC2746, merged in v1.7, introduced the end-of-candidates candidate, where only the
candidateproperty is set to an empty string. However, the schema for the event was untouched in the spec PR.Besides, the WebRTC specification says that only one of those two fields is required when
candidateis not empty (step 3).Fixes #1738 and #1078.
Preview: https://pr1742--matrix-spec-previews.netlify.app