Add 'deprecated:true' to /v1/send_{join,leave} #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The words already say this is deprecated, but it was missing the flag.
|
In an attempt to bring the paper trail to one place: This dates back to matrix-org/matrix-spec-proposals#2547 which was the spec PR for matrix-org/matrix-spec-proposals#1802 The MSC doesn't say it explicitly, but given age of the MSC and surrounding language, the intent appears clear to deprecate the v1 endpoint. Our deprecation policy additionally requires implementations to support deprecated endpoints, making this even safer for a change. It would still require an MSC to remove the deprecated endpoints. |
richvdh
changed the title
turt2live
approved these changes
May 15, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The words already say this is deprecated, but it was missing the flag.
Preview: https://pr1518--matrix-spec-previews.netlify.app