federation-api: Deprecate v1/send_join and v1/send_leave
#1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 tasks
zecakeh
force-pushed
the
zecakeh/deprecate-send-join-leave
branch
from
0405318
to
3d173c6
Compare
|
Did we deprecate the entire module for other deprecated endpoints? I think it makes sense, I just can't remember seeing it before :) |
|
I don't think there are other deprecated endpoints atm. With a string search I only get the tests. The old deprecated client-api sync endpoints are not implemented. |
zecakeh
force-pushed
the
zecakeh/deprecate-send-join-leave
branch
2 times, most recently
from
07947fb
to
4aa30ea
Compare
|
It looks like CI doesn't like having tests in a deprecated module… Unless I'm misunderstanding the issue. |
|
We may be hitting rust-lang/rust#47238 |
|
I've got it to work by moving |
|
Maybe we should move it to be an integration test, to keep the tree clean? |
According to a spec clarification
Otherwise cargo check always complains that we are using a deprecated const. See rust-lang/rust#47238
zecakeh
force-pushed
the
zecakeh/deprecate-send-join-leave
branch
from
2b66ffb
to
95d410a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to a spec clarification.
This required to allow to declare an endpoint as both stable and deprecated in Matrix 1.0.
Preview: https://pr-1556--ruma-docs.surge.sh