Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the appservice ping response duration_ms field as required #1541

Merged
merged 2 commits into from May 24, 2023

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented May 24, 2023

As intended in MSC2659, forgotten in #1516.

Checked with the author in the matrix spec room.

Preview: https://pr1541--matrix-spec-previews.netlify.app

As intended in MSC2659.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner May 24, 2023 19:48
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turt2live turt2live merged commit 089d209 into matrix-org:main May 24, 2023
10 checks passed
@zecakeh zecakeh deleted the appservice-ping-duration-required branch May 25, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants