Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec for MSC2659: application service ping endpoint #1516

Merged
merged 11 commits into from
May 23, 2023
Merged

Add spec for MSC2659: application service ping endpoint #1516

merged 11 commits into from
May 23, 2023

Conversation

tulir
Copy link
Member

@tulir tulir commented May 9, 2023 •
edited by github-actions bot
Loading

@tulir tulir mentioned this pull request May 9, 2023
Merged
@turt2live
Copy link
Member

@tulir is this meant to be ready for review?

@turt2live turt2live added the release-blocker Blocks the next release from happening label May 16, 2023
@tulir
Copy link
Member Author

tulir commented May 16, 2023

Very likely needs some improvements, but yeah I guess most of the important content is there so it can be looked at

@tulir tulir marked this pull request as ready for review May 16, 2023 09:09
@tulir tulir requested a review from a team as a code owner May 16, 2023 09:09
anoadragon453
anoadragon453 requested changes May 18, 2023
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of little things, but generally looks really good. Thanks for doing this!

changelogs/application_service/newsfragments/1516.feature Show resolved Hide resolved
content/application-service-api.md Show resolved Hide resolved
content/application-service-api.md Outdated Show resolved Hide resolved
data/api/client-server/appservice_ping.yaml Outdated Show resolved Hide resolved
data/api/client-server/appservice_ping.yaml Outdated Show resolved Hide resolved
data/api/client-server/appservice_ping.yaml Outdated Show resolved Hide resolved
content/application-service-api.md Outdated Show resolved Hide resolved
data/api/application-service/ping.yaml Outdated Show resolved Hide resolved
data/api/application-service/ping.yaml Outdated Show resolved Hide resolved
data/api/client-server/appservice_ping.yaml Outdated Show resolved Hide resolved
@turt2live turt2live removed their request for review May 19, 2023 03:17
anoadragon453
anoadragon453 approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for tackling all the fixes!

@anoadragon453 anoadragon453 merged commit 9dd9639 into matrix-org:main May 23, 2023
10 checks passed
This was referenced May 24, 2023
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
release-blocker Blocks the next release from happening
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tulir @turt2live @anoadragon453