Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #1423 broke the display of the Server-Server API "Knocking Rooms" header #1572

Closed
midnightveil opened this issue Jun 14, 2023 · 2 comments · Fixed by #1578
Closed

PR #1423 broke the display of the Server-Server API "Knocking Rooms" header #1572

midnightveil opened this issue Jun 14, 2023 · 2 comments · Fixed by #1578
Labels
aesthetic A suggestion or issue relating to the representation of the spec help wanted Interested in contributing to the spec? These would be great additions!

Comments

@midnightveil
Copy link
Contributor

Link to problem area:

https://spec.matrix.org/v1.7/server-server-api/#restricted-rooms

image

Issue
Header isn't displayed properly (it's just raw markdown)

#1423 seems to have introduced the change, given the version in #1407 seems to appear right.
@midnightveil midnightveil added the aesthetic A suggestion or issue relating to the representation of the spec label Jun 14, 2023
@richvdh
Copy link
Member

richvdh commented Jun 14, 2023

Sigh yes, I guess it needs a blank line. A PR to fix it would be very welcome.

@richvdh richvdh added the help wanted Interested in contributing to the spec? These would be great additions! label Jun 14, 2023
@midnightveil
Copy link
Contributor Author

Yeah, I'll send one soonish. Just was finishing up for the day and wanted to actually build a copy so can confirm it works.

@midnightveil midnightveil mentioned this issue Jun 17, 2023
Merged
richvdh pushed a commit that referenced this issue Jun 21, 2023
@midnightveil
Fix headers with custom IDs via the correct syntax (#1578)
b79fa06 
Was previously using <a name="..."> elements which just
add another anchor rather than changing the existing one.
They also use a deprecated HTML attribute and in some cases
broke the header display.

Fixes #1572.

Signed-off-by: Midnight Veil <midnightveil@fea.st>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aesthetic A suggestion or issue relating to the representation of the spec help wanted Interested in contributing to the spec? These would be great additions!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix headers with custom IDs via the correct syntax
2 participants
@richvdh @midnightveil