Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix headers with custom IDs via the correct syntax #1578

Merged
merged 3 commits into from Jun 21, 2023
Merged

Fix headers with custom IDs via the correct syntax #1578

merged 3 commits into from Jun 21, 2023

Conversation

midnightveil
Copy link
Contributor

@midnightveil midnightveil commented Jun 17, 2023 •
edited by github-actions bot

@midnightveil midnightveil requested a review from a team as a code owner June 17, 2023 06:56
richvdh
richvdh requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As the CI is reporting, there is now a broken link. Looks like it is here:

matrix-spec/content/client-server-api/modules/end_to_end_encryption.md

Line 138 in 0a502a3

`/sync`](#a-namee2e-extensions-to-sync-extensions-to-sync), about the number of

@midnightveil
Fix headers with custom IDs via the correct syntax
bac4a68 
Was previously using <a name="..."> elements which just
add another anchor rather than changing the existing one.
They also use a deprecated HTML attribute and in some cases
broke the header display.

Fixes #1572.

Signed-off-by: Midnight Veil <midnightveil@fea.st>
@midnightveil
Copy link
Contributor Author

Should be fixed.

@richvdh richvdh self-requested a review June 21, 2023 12:41
richvdh
richvdh approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@richvdh richvdh merged commit b79fa06 into matrix-org:main Jun 21, 2023
10 checks passed
@zecakeh zecakeh mentioned this pull request Aug 21, 2023
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PR #1423 broke the display of the Server-Server API "Knocking Rooms" header
2 participants
@midnightveil @richvdh