Switch to ordered list for server name resolution steps #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have updated the list of Resolving server names in step 3 from unordered list to ordered list. Because we care about its order
mohit1523
changed the title
richvdh
requested changes
Aug 18, 2023
| @@ -0,0 +1 @@ | |||
| I have updated the list of Resolving server names in step 3 from unordered list to ordered list. Because we care about its order | |||
There was a problem hiding this comment.
This style isn't consistent with our regular changelog entries. I suggest you have a look at the other entries in https://spec.matrix.org/v1.7/changelog/ and try to follow their style.
richvdh
changed the title
|
@richvdh sir, I have update the changelog entries in the newsfragments section. Please review it. |
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the list of Resolving server names in step 3 from unordered list to ordered list. Because we care about its order
Fixes #1567.
Preview: https://pr1623--matrix-spec-previews.netlify.app