Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server name resolution uses bullets instead of numbers for Step 3 #1567

Closed
turt2live opened this issue Jun 13, 2023 · 5 comments · Fixed by #1623
Closed

Server name resolution uses bullets instead of numbers for Step 3 #1567

turt2live opened this issue Jun 13, 2023 · 5 comments · Fixed by #1623
Labels
A-S2S Server-to-Server API (federation) aesthetic A suggestion or issue relating to the representation of the spec clarification An area where the expected behaviour is understood, but the spec could do with being more explicit help wanted Interested in contributing to the spec? These would be great additions!

Comments

@turt2live
Copy link
Member

Link to problem area: https://spec.matrix.org/v1.7/server-server-api/#resolving-server-names

Issue
It's super minor, but under Step 3 should be a numbered list given we care about order.

@turt2live turt2live added help wanted Interested in contributing to the spec? These would be great additions! clarification An area where the expected behaviour is understood, but the spec could do with being more explicit A-S2S Server-to-Server API (federation) aesthetic A suggestion or issue relating to the representation of the spec labels Jun 13, 2023
@mohit1523
Copy link
Contributor

Sir, I can solve issue #1567.

It just requires a minor change in the code and the issue will be resolved .
So, please guide me how I can make the changes in the repository.

Thank You

@richvdh
Copy link
Member

richvdh commented Aug 17, 2023

So, please guide me how I can make the changes in the repository.

These guides may be helpful:

https://opensource.guide/how-to-contribute/#opening-a-pull-request
https://github.com/matrix-org/matrix-spec/blob/main/CONTRIBUTING.rst

@mohit1523
Copy link
Contributor

@richvdh sir, I am unable to find the file in the repository via which I am able to solve this issue.
So please can you mention the filename so that it will be really helpful for me to solve the issue.

@richvdh
Copy link
Member

richvdh commented Aug 17, 2023

Previously you said:

It just requires a minor change in the code and the issue will be resolved .

Sounds like you already know what needs changing? No?

It's not very hard to find: https://github.com/search?q=repo%3Amatrix-org%2Fmatrix-spec+%22If+the+hostname+is+not+an+IP+literal%22&type=code

I feel like you're wasting people's time.

@mohit1523
Copy link
Contributor

mohit1523 commented Aug 18, 2023

@richvdh sir, I know what needs to be change but I have having difficulty in finding the file.

I have solved the issue #1567.

Please review it.

Link :- #1623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-S2S Server-to-Server API (federation) aesthetic A suggestion or issue relating to the representation of the spec clarification An area where the expected behaviour is understood, but the spec could do with being more explicit help wanted Interested in contributing to the spec? These would be great additions!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants