Replace all mentions of Swagger by OpenAPI #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
KitsuneRal
reviewed
Sep 12, 2023
There was a problem hiding this comment.
I personally am quite happy with the rename including the scripts; but it would be great to have at least one other opinion from SCT, in particular either of @turt2live, @anoadragon453, @richvdh.
anoadragon453
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
I'm happy with this as well, and it makes sense if the Swagger naming is no longer technically true.
I don't have any muscle memory for these scripts, so renaming them does not affect me. As long as any of our tooling that uses them is still happy, I'm happy.
richvdh
reviewed
Sep 19, 2023
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
richvdh
reviewed
Sep 19, 2023
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OpenAPI 3.1 is not compatible with Swagger anymore, it might be confusing to keep the old name or the double naming.
The last change that renames the scripts might be more controversial, as it might be confusing for people used to the old script names, so it can be reverted if wanted.
Preview: https://pr1633--matrix-spec-previews.netlify.app