-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all mentions of Swagger by OpenAPI #1633
Conversation
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally am quite happy with the rename including the scripts; but it would be great to have at least one other opinion from SCT, in particular either of @turt2live, @anoadragon453, @richvdh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this as well, and it makes sense if the Swagger naming is no longer technically true.
I don't have any muscle memory for these scripts, so renaming them does not affect me. As long as any of our tooling that uses them is still happy, I'm happy.
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Since OpenAPI 3.1 is not compatible with Swagger anymore, it might be confusing to keep the old name or the double naming.
The last change that renames the scripts might be more controversial, as it might be confusing for people used to the old script names, so it can be reverted if wanted.
Preview: https://pr1633--matrix-spec-previews.netlify.app