Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the deprecation policy of HTML tags. #1732

Merged
merged 6 commits into from Mar 3, 2024
Merged

Document the deprecation policy of HTML tags. #1732

merged 6 commits into from Mar 3, 2024

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Feb 26, 2024 •
edited

Replace it with s or del, as per MSC4077.

It also adds an info box as suggested in matrix-org/matrix-spec-proposals#4077 (comment).

Closes #1492.

Preview: https://pr1732--matrix-spec-previews.netlify.app

@zecakeh
Deprecate strike HTML tag
493200b 
Replace it with `s` or `del`.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner February 26, 2024 14:16
@zecakeh
Add changelog
4597fcd 
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh
Copy link
Contributor Author

zecakeh commented Feb 26, 2024 •
edited

Woops, I just saw that #1629 was reopened for this. Should I keep this open only for the deprecation info box?

Any changes here can be moved to the other PR, if that simplifies things.

@turt2live turt2live mentioned this pull request Feb 26, 2024
Merged
turt2live
turt2live requested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've accepted #1629 to cover the strike->s change, which I believe should allow this PR to handle the addition of a note about HTML specification changes (which the changelog will need to mention).

content/client-server-api/modules/instant_messaging.md Show resolved Hide resolved
content/client-server-api/modules/instant_messaging.md Outdated Show resolved Hide resolved
content/client-server-api/modules/instant_messaging.md Outdated Show resolved Hide resolved
@zecakeh
Merge branch 'main' into msc4077
05d0816 
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh
Remove strike deprecation and add added-in annotation
34579a6 
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh changed the title Deprecate strike HTML tag Document the deprecation policy of HTML tags. Feb 27, 2024
@zecakeh zecakeh closed this Feb 27, 2024
@zecakeh zecakeh reopened this Feb 27, 2024
@zecakeh zecakeh mentioned this pull request Feb 27, 2024
Closed
@zecakeh @uhoreg
Add link to HTML standard
4982abb 
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
turt2live
turt2live approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turt2live turt2live enabled auto-merge (squash) March 3, 2024 00:10
@turt2live turt2live merged commit 4e1b364 into matrix-org:main Mar 3, 2024
12 checks passed
@zecakeh zecakeh deleted the msc4077 branch March 3, 2024 08:32
@zecakeh zecakeh mentioned this pull request Mar 7, 2024
Closed
28 tasks
@Mikaela Mikaela mentioned this pull request Mar 10, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhoreg uhoreg uhoreg left review comments

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated strike tag in custom html
3 participants
@zecakeh @uhoreg @turt2live