Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow setting m.push_rules account data directly. #1763

Merged
merged 7 commits into from Mar 21, 2024
Merged

Do not allow setting m.push_rules account data directly. #1763

merged 7 commits into from Mar 21, 2024

Conversation

clokep
Copy link
Contributor

@clokep clokep commented Mar 21, 2024 •
edited by github-actions bot

@clokep clokep mentioned this pull request Mar 21, 2024
Merged
@clokep clokep marked this pull request as ready for review March 21, 2024 20:09
@clokep clokep requested a review from a team as a code owner March 21, 2024 20:09
turt2live
turt2live reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm - thanks for writing it up! A few nitpicks and different word suggestions.

content/client-server-api/modules/account_data.md Outdated Show resolved Hide resolved
changelogs/client_server/newsfragments/1763.clarification Outdated Show resolved Hide resolved
content/client-server-api/modules/account_data.md Outdated Show resolved Hide resolved
content/client-server-api/modules/account_data.md Outdated Show resolved Hide resolved
clokep and others added 5 commits March 21, 2024 17:15
@clokep @turt2live
Update 1763.clarification
aa722c8 
Co-authored-by: Travis Ralston <travpc@gmail.com>
@clokep @turt2live
add change notice
8c90e94 
Co-authored-by: Travis Ralston <travpc@gmail.com>
@clokep @turt2live
clarify read status
d0a4dd1 
Co-authored-by: Travis Ralston <travpc@gmail.com>
@clokep
Fix link for push rules.
17a18c1
@clokep
Refer to the error response
3a47f58
@clokep
Copy link
Contributor Author

clokep commented Mar 21, 2024

I think this is ready for another look!

@clokep clokep requested a review from turt2live March 21, 2024 21:28
turt2live
turt2live approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turt2live turt2live merged commit 7c19d24 into matrix-org:main Mar 21, 2024
12 checks passed
@clokep clokep deleted the clokep/push-rules-account-data branch March 22, 2024 13:00
@zecakeh zecakeh mentioned this pull request Mar 22, 2024
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clokep @turt2live