Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow setting m.push_rules account data directly. #1763

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Do not allow setting m.push_rules account data directly. #1763

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eebb9ca
Do not allow setting m.push_rules account data directly.
clokep Mar 21, 2024
ebb1ebe
Newsfragment
clokep Mar 21, 2024
aa722c8
Update 1763.clarification
clokep Mar 21, 2024
8c90e94
add change notice
clokep Mar 21, 2024
d0a4dd1
clarify read status
clokep Mar 21, 2024
17a18c1
Fix link for push rules.
clokep Mar 21, 2024
3a47f58
Refer to the error response
clokep Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/client_server/newsfragments/1763.clarification
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Clarify that the `m.push_rules` account data type cannot be set using the `/account_data` API.
clokep marked this conversation as resolved.
Show resolved Hide resolved
7 changes: 6 additions & 1 deletion content/client-server-api/modules/account_data.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,9 @@ These events can also be received in a `/events` response or in the

Servers MUST reject clients from setting account data for event types
that the server manages. Currently, this only includes
[m.fully\_read](#mfully_read).
[`m.fully_read`](#mfully_read) and [`m.push_rules`](#mfully_read).
This applies to both global and room-specific account data.
clokep marked this conversation as resolved.
Show resolved Hide resolved
clokep marked this conversation as resolved.
Show resolved Hide resolved

Servers must allow clients to read the above event types as normal. Note that
`m.fully_read` only exists for room-specific account data and `m.push_rules`
only exists for global account data.
clokep marked this conversation as resolved.
Show resolved Hide resolved
Loading