-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarifications around encoding of data within verification QR codes #1839
Conversation
ce618c9
to
19f3e21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're in this area, you could clarify that the keys in key1 and key2 are public keys. For example:
- the second key, as 32 bytes. The key to use depends on the mode field
- if
0x00
, then what the device thinks the other user's master cross-signing public key is- if
0x01
, then what the device thinks the other device's Ed25519 signing public key is- if
0x02
, then what the device thinks the user's master cross-signing public key is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor suggestions with respect to #1782.
The QR codes to be displayed and scanned using this format will encode binary | ||
strings in the general form: | ||
The QR codes to be displayed and scanned must be | ||
[ISO/IEC 18004:2015](https://www.iso.org/standard/62021.html) compatible and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[sadly yes, the spec for QR codes is copyrighted; this seems to be the best we can do.]
Thank you! Co-authored-by: Johannes Marbach <n0-0ne+github@mailbox.org> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Good thought. Now done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting these clarifications across the line!
Pull Request Checklist
Currently the spec is specific about the contents of the binary data to be present within a QR, but it does not specify how that data should be encoded within a QR.
I've checked the original MSC1544 but don't see any obvious discussion around this. Also, no discussion in the spec PR.
As such, I assume this is an oversight.
I do have a hesitation about linking out to the ISO spec as it is not "open".
Preview: https://pr1839--matrix-spec-previews.netlify.app