Clarifications around encoding of data within verification QR codes #1839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughns
force-pushed
the
hughns/qr-code-encoding
branch
from
ce618c9 to
19f3e21
Compare
sumnerevans
reviewed
Jun 3, 2024
sumnerevans
reviewed
Jun 5, 2024
Contributor
sumnerevans
left a comment
sumnerevans
left a comment
There was a problem hiding this comment.
While you're in this area, you could clarify that the keys in key1 and key2 are public keys. For example:
- the second key, as 32 bytes. The key to use depends on the mode field
- if
0x00, then what the device thinks the other user's master cross-signing public key is- if
0x01, then what the device thinks the other device's Ed25519 signing public key is- if
0x02, then what the device thinks the user's master cross-signing public key is
richvdh
requested changes
Jun 11, 2024
| The QR codes to be displayed and scanned using this format will encode binary | ||
| strings in the general form: | ||
| The QR codes to be displayed and scanned must be | ||
| [ISO/IEC 18004:2015](https://www.iso.org/standard/62021.html) compatible and |
Member
There was a problem hiding this comment.
[sadly yes, the spec for QR codes is copyrighted; this seems to be the best we can do.]
Thank you! Co-authored-by: Johannes Marbach <n0-0ne+github@mailbox.org> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Member
Author
Good thought. Now done. |
sumnerevans
approved these changes
Jun 12, 2024
Contributor
sumnerevans
left a comment
sumnerevans
left a comment
There was a problem hiding this comment.
Thanks for getting these clarifications across the line!
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Currently the spec is specific about the contents of the binary data to be present within a QR, but it does not specify how that data should be encoded within a QR.
I've checked the original MSC1544 but don't see any obvious discussion around this. Also, no discussion in the spec PR.
As such, I assume this is an oversight.
I do have a hesitation about linking out to the ISO spec as it is not "open".
Preview: https://pr1839--matrix-spec-previews.netlify.app