Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing word header #1852

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Add missing word header #1852

merged 2 commits into from
Jun 11, 2024

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Jun 10, 2024 •
edited by github-actions bot
Loading

Pull Request Checklist

Preview: https://pr1852--matrix-spec-previews.netlify.app

@Johennes
Add missing word header
6b1c123 
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes
Add changelog
d61a661
@Johennes Johennes marked this pull request as ready for review June 10, 2024 08:21
@Johennes Johennes requested a review from a team as a code owner June 10, 2024 08:21
@Johennes
Copy link
Contributor Author

On a related note, it seems like sending the retry_after_ms response field was downgraded from SHOULD to MAY in 1.10. I think for a proper deprecation it should have stayed SHOULD so that servers include it whenever they set the new header to support clients that haven't yet caught up with the spec. Given that this was already released, I suppose there's no point in changing it yet again though?

uhoreg
uhoreg approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks

@uhoreg uhoreg merged commit 520b839 into matrix-org:main Jun 11, 2024
12 checks passed
@zecakeh zecakeh mentioned this pull request Jun 20, 2024
Closed
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhoreg uhoreg uhoreg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Johennes @uhoreg