Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete endpoint for pushers #233

Open
mujx opened this issue Mar 5, 2017 · 2 comments
Open

delete endpoint for pushers #233

mujx opened this issue Mar 5, 2017 · 2 comments
Labels
A-Client-Server Issues affecting the CS API enhancement A suggestion for a relatively simple improvement to the protocol

Comments

@mujx
Copy link
Contributor

mujx commented Mar 5, 2017

The description of the kind parameter from the current version.

The kind of pusher to configure. "http" makes a pusher that sends HTTP pokes. null deletes the pusher.

I would suggest creating a new endpoint like DELETE /pusher to delete a pusher and be more explicit about the intend instead of hiding it inside an arbitrary parameter.

@turt2live turt2live added the enhancement A suggestion for a relatively simple improvement to the protocol label Jul 19, 2018
@turt2live turt2live added the A-Client-Server Issues affecting the CS API label Feb 6, 2019
@turt2live
Copy link
Member

Not to mention it makes it nearly impossible to troubleshoot as a client dev whether your pusher is being deleted or added successfully by the server. 200 OK just means it did something, but it is hard to tell what at a glance.

@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@richvdh richvdh changed the title Improve delete semantics for pushers delete endpoint for pushers Nov 15, 2022
@richvdh
Copy link
Member

richvdh commented Nov 15, 2022

Another reason for this is that there's basically nowhere else in the protocol that we allow null (cf #472)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client-Server Issues affecting the CS API enhancement A suggestion for a relatively simple improvement to the protocol
Projects
None yet
Development

No branches or pull requests

3 participants