Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinging people is too hard #353

Closed
turt2live opened this issue Aug 22, 2018 · 5 comments · Fixed by matrix-org/matrix-spec-proposals#3952
Closed

Pinging people is too hard #353

turt2live opened this issue Aug 22, 2018 · 5 comments · Fixed by matrix-org/matrix-spec-proposals#3952
Labels
A-Client-Server Issues affecting the CS API enhancement A suggestion for a relatively simple improvement to the protocol

Comments

@turt2live
Copy link
Member

Currently the best way to ping someone is to use their display name or user ID and hope that they have push rules set up to catch that. This isn't great, and even paired with matrix-org/matrix-spec-proposals#1067 the problem isn't totally solved.

Instead of having to apply regex parsing on event bodies, hoping to catch a keyword, we could use an array of some kind to list the users to mention in the event. We can still keep the more useful push rules, however some of the existing ones would need to be altered to support this mention functionality.

This is one solution for which I'm looking for feedback before bothering to go through with a formal proposal:

A mentions array be added to every event listing the user IDs to ping. These user IDs must appear in the body in the format <@userid:domain.com>. This provides a level of backwards compatibility in that it still can ping people on servers/clients that do not recognize the mentions array, and it ensures that people aren't secretly mentioned. The formatted_body should keep the current standard for a pill to ensure it doesn't get lost.

Clients would be able to parse the <@userid:domain.com> if they wanted to make it easier to read, although leaving it as-is isn't the worst.

The reason for not choosing a keyword:userid map for mentions is to avoid abuse where someone says {"cat": "@travis:t2l.io"} and pings several times.

@turt2live turt2live added the enhancement A suggestion for a relatively simple improvement to the protocol label Aug 22, 2018
@Half-Shot
Copy link
Contributor

This looks largely fine to me, and solves my problem of bridges not being able to ping people without mutating a nick into a displayname. I assume the intention is to transform <@userid:domain.com> into pills?

@turt2live
Copy link
Member Author

If the client wishes, yes.

@turt2live turt2live added the A-Client-Server Issues affecting the CS API label Feb 6, 2019
@yangm97
Copy link

yangm97 commented Aug 8, 2019

Another issue with the current mention system is that you lose old highlights after changing your name.

image

@snekmatrix
Copy link


i'm told this misdirected pinging is related

@richvdh
Copy link
Member

richvdh commented Aug 27, 2020

are there any thoughts on how to apply this to e2e rooms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client-Server Issues affecting the CS API enhancement A suggestion for a relatively simple improvement to the protocol
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants