Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2463: Exclusion of MXIDs in push rules content matching #2463

Closed
wants to merge 1 commit into from
Closed

MSC2463: Exclusion of MXIDs in push rules content matching #2463

wants to merge 1 commit into from

Conversation

pacien
Copy link

@pacien pacien commented Mar 18, 2020 •
edited by richvdh
Loading

@pacien pacien force-pushed the msc-exclusion-of-mxids-in-push-rules-content-matching branch from 2544fd2 to 12d8bc2 Compare March 18, 2020 17:45
@pacien pacien changed the title MSC: Exclusion of MXIDs in push rules content matching MSC2463: Exclusion of MXIDs in push rules content matching Mar 18, 2020
@pacien pacien force-pushed the msc-exclusion-of-mxids-in-push-rules-content-matching branch from 12d8bc2 to 84dccf5 Compare March 18, 2020 17:46
@pacien
Copy link
Author

pacien commented Mar 18, 2020

CC: @Half-Shot

@turt2live
Copy link
Member

@pacien please don't forget to sign off on your contribution per the contributing guidelines

@turt2live turt2live added proposal A matrix spec change proposal proposal-in-review labels Mar 18, 2020
@pacien pacien force-pushed the msc-exclusion-of-mxids-in-push-rules-content-matching branch from 84dccf5 to 3c7d417 Compare March 18, 2020 19:40
@turt2live turt2live self-requested a review March 27, 2020 02:45
@turt2live turt2live added the kind:feature MSC for not-core and not-maintenance stuff label Apr 20, 2020
@richvdh
Copy link
Member

richvdh commented Aug 11, 2020 •
edited
Loading

related: matrix-org/matrix-spec#353

@richvdh richvdh mentioned this pull request Aug 11, 2020
Closed
@lieuwex lieuwex mentioned this pull request Aug 22, 2020
Closed
turt2live
turt2live requested changes Aug 26, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please wrap your lines at roughly 120 characters for review.

@pacien
MSC: Exclusion of MXIDs in push rules content matching
f372734 
Signed-off-by: pacien <pacien.trangirard@pacien.net>
@pacien pacien force-pushed the msc-exclusion-of-mxids-in-push-rules-content-matching branch from 3c7d417 to f372734 Compare August 26, 2020 21:00
@pacien
Copy link
Author

pacien commented Aug 26, 2020

@turt2live folded at 120 chars and amended.

@pacien pacien requested a review from turt2live August 26, 2020 21:01
@turt2live turt2live removed their request for review November 10, 2020 05:26
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
@richvdh richvdh mentioned this pull request Nov 22, 2021
Closed
@JokerGermany JokerGermany mentioned this pull request Jan 13, 2022
Closed
@pacien pacien mentioned this pull request Jan 13, 2023
Merged
@turt2live
Copy link
Member

Thank you for the MSC! The code core team has been working in this area recently, and the SCT is currently aiming to put forward #3952 as the MSC to solve the problem space. As such, I'm proposing we reject this MSC in favour of MSC3952.

Disagreements from the SCT as a whole are still possible on either MSC, and concerns can be raised on both/either MSC to prevent FCP from going forward. The author can additionally close the MSC at any time to avoid the formal FCP process, marking the MSC as "obsolete" in this case.

If you have any questions/concerns about the process, let us know in the #matrix-spec:matrix.org room on Matrix.

@mscbot fcp close

@mscbot
Copy link
Collaborator

mscbot commented Mar 21, 2023 •
edited by anoadragon453
Loading

Team member @turt2live has proposed to close this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-close labels Mar 21, 2023
@turt2live turt2live added this to Needs idea feedback / initial review in Spec Core Team Backlog via automation Mar 21, 2023
@turt2live turt2live moved this from Needs idea feedback / initial review to Ready for FCP ticks in Spec Core Team Backlog Mar 21, 2023
@richvdh
Copy link
Member

richvdh commented Mar 21, 2023

I think it's fair to say that it's unlikely we'd adopt this MSC in its current form, but I am slightly hesitant as it seems premature to close it before MSC3952 is actually approved.

@clokep
Copy link
Contributor

clokep commented Apr 27, 2023

MSC3952 is merged now, so I suspect we should move ahead with the proposal to close this.

@mscbot
Copy link
Collaborator

mscbot commented May 2, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels May 2, 2023
@turt2live turt2live moved this from Ready for FCP ticks to In FCP in Spec Core Team Backlog May 4, 2023
@mscbot
Copy link
Collaborator

mscbot commented May 7, 2023

The final comment period, with a disposition to close, as per the review above, is now complete.

@mscbot mscbot closed this May 7, 2023
@mscbot mscbot added finished-final-comment-period and removed disposition-close final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels May 7, 2023
@turt2live turt2live moved this from In FCP to Done to some definition in Spec Core Team Backlog May 7, 2023
@turt2live turt2live added rejected A proposal which has been rejected for inclusion in the spec and removed finished-final-comment-period labels May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live requested changes

Assignees
No one assigned
Labels
kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal rejected A proposal which has been rejected for inclusion in the spec
Projects
Spec Core Team Backlog
Status: Done to some definition
Spec Core Team Backlog
  
Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pacien @turt2live @richvdh @mscbot @clokep