Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication data should be a map of strings to anything, not to objects #716

Closed
KitsuneRal opened this issue Nov 6, 2020 · 0 comments · Fixed by #1115
Closed

Authentication data should be a map of strings to anything, not to objects #716

KitsuneRal opened this issue Nov 6, 2020 · 0 comments · Fixed by #1115

Comments

@KitsuneRal
Copy link
Member

auth_data.yml says that additionalProperties should be of type: object, which does not hold in many cases; in its own example, example_credential is a string, not an object.
@KitsuneRal KitsuneRal added the spec-bug Something which is in the spec, but is wrong label Nov 6, 2020
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@turt2live turt2live added spec-problem and removed spec-bug Something which is in the spec, but is wrong labels May 28, 2022
KitsuneRal added a commit that referenced this issue Jun 12, 2022
@KitsuneRal
auth_data.yaml: formally allow it to be non-object
6276749 
Closes #716.
@KitsuneRal KitsuneRal mentioned this issue Jun 12, 2022
Merged
richvdh pushed a commit that referenced this issue Jun 14, 2022
@KitsuneRal
auth_data.yaml: formally allow it to be non-object (#1115)
cbdd889 
Closes #716.

Signed-off-by: Alexey Rusakov Kitsune-Ral@users.sf.net
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

auth_data.yaml: formally allow it to be non-object matrix-org/matrix-spec
2 participants
@turt2live @KitsuneRal