Remove origin from unsigned_pdu_base.yaml #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't serve a useful purpose, is not enforced to be present by Synapse and already being omitted by at least one homeserver implementation.
richvdh
reviewed
Mar 19, 2022
|
LGTM otherwise, but I'd like to check if anyone else in the SCT has an opinion. |
jplatte
added a commit
to ruma/ruma
that referenced
this pull request
Mar 29, 2022
It has been removed from the spec, for details see matrix-org/matrix-spec#998
jplatte
added a commit
to ruma/ruma
that referenced
this pull request
Mar 30, 2022
It has been removed from the spec, for details see matrix-org/matrix-spec#998
66 tasks
gnieto
added a commit
to gnieto/sytest
that referenced
this pull request
Sep 25, 2022
Related to: matrix-org/matrix-spec#998 Setting `origin` field in PDUs is not required anymore, so I've removed assertions and assignments to this field.
This was referenced Sep 25, 2022
neilalexander
added a commit
to matrix-org/gomatrixserverlib
that referenced
this pull request
Sep 26, 2022
neilalexander
added a commit
to matrix-org/dendrite
that referenced
this pull request
Sep 26, 2022
neilalexander
added a commit
to matrix-org/gomatrixserverlib
that referenced
this pull request
Sep 26, 2022
This nukes the `origin` field from PDUs as per matrix-org/matrix-spec#998.
neilalexander
added a commit
to matrix-org/dendrite
that referenced
this pull request
Sep 26, 2022
This nukes the `origin` field from PDUs as per matrix-org/matrix-spec#998, matrix-org/gomatrixserverlib#341.
This was referenced Apr 4, 2023
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't serve a useful purpose, is not enforced to be present by Synapse and already being omitted by at least one homeserver implementation.
Fixes one half of #374.
Preview: https://pr998--matrix-spec-previews.netlify.app