Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove origin from unsigned_pdu_base.yaml #998

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Remove origin from unsigned_pdu_base.yaml #998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9b6bbe
Remove origin from unsigned_pdu_base.yaml
jplatte Mar 17, 2022
8c008c6
Add newsfragment for PDU origin field removal
jplatte Mar 17, 2022
ade5eb1
fixup! Remove origin from unsigned_pdu_base.yaml
jplatte Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/server_server/newsfragments/998.clarification
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove `origin` field from PDUs which exists on many but not all PDUs in practice and doesn't serve an actual purpose.
5 changes: 0 additions & 5 deletions data/api/server-server/definitions/unsigned_pdu_base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ properties:
type: string
description: The ID of the user sending the event.
example: "@someone:matrix.org"
origin:
jplatte marked this conversation as resolved.
Show resolved Hide resolved
type: string
description: The `server_name` of the homeserver that created this event.
example: "matrix.org"
origin_server_ts:
type: integer
format: int64
Expand Down Expand Up @@ -128,7 +124,6 @@ required:
- event_id
- room_id
- sender
- origin
- origin_server_ts
- type
- content
Expand Down