Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec for refresh tokens #1056

Merged
merged 7 commits into from
Jun 2, 2022
Merged

Add spec for refresh tokens #1056

merged 7 commits into from
Jun 2, 2022

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented May 10, 2022 •
edited by github-actions bot

@uhoreg uhoreg marked this pull request as ready for review May 10, 2022 19:19
@uhoreg uhoreg requested a review from a team as a code owner May 10, 2022 19:19
@turt2live
Copy link
Member

(pull latest to fix CI - changelog complaint isn't with your changelog but rather a commit on main)

@turt2live turt2live mentioned this pull request May 20, 2022
Merged
richvdh
richvdh reviewed May 24, 2022
View reviewed changes
content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
data/api/client-server/refresh.yaml Show resolved Hide resolved
@turt2live turt2live added the release-blocker Blocks the next release from happening label May 28, 2022
@turt2live turt2live added this to Requires spec review (post-FCP) in Spec Core Team Backlog May 30, 2022
@uhoreg uhoreg requested a review from richvdh May 31, 2022 20:24
richvdh
richvdh approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

content/client-server-api/_index.md Outdated Show resolved Hide resolved
data/api/client-server/login.yaml Outdated Show resolved Hide resolved
data/api/client-server/refresh.yaml Outdated Show resolved Hide resolved
data/api/client-server/refresh.yaml Outdated Show resolved Hide resolved
data/api/client-server/registration.yaml Outdated Show resolved Hide resolved
uhoreg and others added 2 commits June 2, 2022 16:17
@uhoreg @richvdh
Apply suggestions from code review
ef3df9d 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@uhoreg
don't need securityDefinitions since we don't use access token
9bf02ad
@uhoreg uhoreg merged commit 8d82366 into matrix-org:main Jun 2, 2022
@turt2live turt2live moved this from Requires spec review (post-FCP) to Done to some definition in Spec Core Team Backlog Jun 2, 2022
This was referenced Jun 3, 2022
Closed
Closed
@richvdh richvdh mentioned this pull request Jun 9, 2022
Closed
uhoreg added a commit to zecakeh/matrix-spec that referenced this pull request Jun 13, 2022
@uhoreg
Merge changelog with changelog for matrix-org#1056
3fbaced
@richvdh richvdh mentioned this pull request Feb 17, 2023
Closed
@hughns hughns mentioned this pull request Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
release-blocker Blocks the next release from happening
Projects
Spec Core Team Backlog
  
Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uhoreg @turt2live @richvdh