Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove declared-invalid invite->knock restriction from auth rules #1175

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Remove declared-invalid invite->knock restriction from auth rules #1175

merged 3 commits into from
Aug 2, 2022

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Jul 19, 2022 •
edited by github-actions bot
Loading

@turt2live turt2live mentioned this pull request Jul 19, 2022
Merged
@turt2live turt2live marked this pull request as ready for review July 19, 2022 19:35
@turt2live turt2live requested a review from a team as a code owner July 19, 2022 19:35
@turt2live turt2live added this to Requires spec review (post-FCP) in Spec Core Team Backlog Jul 19, 2022
@turt2live turt2live merged commit b36d4ef into main Aug 2, 2022
@turt2live turt2live deleted the travis/spec/fix-invite-knock-transition branch August 2, 2022 23:20
@turt2live turt2live moved this from Requires spec review (post-FCP) to Done to some definition in Spec Core Team Backlog Aug 2, 2022
@zecakeh zecakeh mentioned this pull request Sep 4, 2022
Closed
54 tasks
@zecakeh zecakeh mentioned this pull request Sep 30, 2022
Merged
@kegsay kegsay mentioned this pull request Jan 16, 2024
Closed
kegsay added a commit to kegsay/matrix-spec that referenced this pull request Jan 23, 2024
@kegsay
Clarify that invite->knock is not a valid transition
01087be 
This reverts matrix-org#1175

See matrix-org#1710
@kegsay kegsay mentioned this pull request Jan 23, 2024
Merged
@Gnuxie Gnuxie mentioned this pull request Jan 23, 2024
Open
turt2live pushed a commit that referenced this pull request Feb 21, 2024
@kegsay
Clarify that invite->knock is not a valid transition (#1717)
c4e69d8 
This reverts #1175

See #1710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Spec Core Team Backlog
  
Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invite -> knock membership change is actually illegal
2 participants
@turt2live @KitsuneRal