Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix definition of data-mx-color values #1260

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Fix definition of data-mx-color values #1260

merged 3 commits into from
Oct 4, 2022

Conversation

progval
Copy link
Contributor

@progval progval commented Oct 1, 2022 •
edited by github-actions bot
Loading

@progval progval requested a review from a team as a code owner October 1, 2022 07:02
@progval
Copy link
Contributor Author

progval commented Oct 1, 2022

Signed-off-by: Valentin Lorentz <progval+git @ progval.net>

@progval progval mentioned this pull request Oct 1, 2022
Merged
turt2live
turt2live reviewed Oct 1, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

changelogs/client_server/newsfragments/1260.clarification Outdated Show resolved Hide resolved
@progval @turt2live
Update changelogs/client_server/newsfragments/1260.clarification
09ef9e9 
Co-authored-by: Travis Ralston <travpc@gmail.com>
turt2live
turt2live approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@turt2live turt2live merged commit 460bea4 into matrix-org:main Oct 4, 2022
@progval progval deleted the patch-1 branch October 5, 2022 18:05
clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
@progval @turt2live @clokep
Fix definition of data-mx-color values (matrix-org#1260)
3a22507 
* Fix definition of `data-mx-color` values

* Create 1260.clarification

* Update changelogs/client_server/newsfragments/1260.clarification

Co-authored-by: Travis Ralston <travpc@gmail.com>

Co-authored-by: Travis Ralston <travpc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@progval @turt2live