Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send heroes for nameless rooms on send_join #1425

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Send heroes for nameless rooms on send_join #1425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24c117c
send heroes for nameless rooms on send_join
uhoreg Jan 31, 2023
a831028
add changelog
uhoreg Jan 31, 2023
f5d4350
fix typo
uhoreg Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/server_server/newsfragments/1425.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Note that `/_matrix/federation/v2/send_join` should include heroes for nameless rooms, even when allowed to omit membership events, per [MSC3943](https://github.com/matrix-org/matrix-doc/pull/3943).
10 changes: 10 additions & 0 deletions data/api/server-server/joins-v2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,16 @@ paths:
If `true`, indicates that that calling server can accept a reduced
response, in which membership events are omitted from `state` and
redundant events are omitted from `auth_chain`.

If the room to be joined has no `m.room.name` nor
`m.room.canonical_alias` events in its current state, the resident
server should determine the room members who would be included in
the `m.heroes` property of the room summary as defined in the
[Client-Server /sync
response](/client-server-api/#get_matrixclientv3sync). The resident
server should include these members' membership events in the
response `state` field, and include the auth chains for these
membership events in the response `auth_chain` field.
x-addedInMatrixVersion: "1.6"
- in: body
name: body
Expand Down