Spec implicit filter event limit #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stuart Mumford <stuart@cadair.com>
richvdh
requested changes
Mar 14, 2023
| @@ -14,7 +14,7 @@ | |||
| title: EventFilter | |||
| properties: | |||
| limit: | |||
| description: The maximum number of events to return. | |||
| description: The maximum number of events to return. If not specified defaults to 10. | |||
There was a problem hiding this comment.
I'm not entirely sure we should mandate this, or that we can mandate it, without going through the MSC process: it may well be that non-synapse implementations use a different default.
I think what we need to say instead is that if it's not specified, servers should use an implementation-specific default.
The limit param on GET /threads has sensible wording here.
There was a problem hiding this comment.
Ok, that makes more sense, I wasn't sure I had understood the original issue.
|
Also: please could you take a look at https://github.com/matrix-org/matrix-spec/blob/main/CONTRIBUTING.rst, particularly with respect to the need for a changelog file? |
Signed-off-by: Stuart Mumford <stuart@cadair.com>
Signed-off-by: Stuart Mumford <stuart@cadair.com>
Cadair
force-pushed
the
spec_implicit_sync_limit
branch
from
ee32fd2
to
acba8e9
Compare
47 tasks
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
Signed-off-by: Stuart Mumford <stuart@cadair.com>
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address #200
I think I am understanding the issue correctly.
I took the default out of synapse I haven't looked in any other implementations to see if they also use the default of 10.Preview: https://pr1463--matrix-spec-previews.netlify.app