Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix m.call.negotiate schema and example #1546

Merged
merged 4 commits into from Oct 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -0,0 +1 @@
Fix `m.call.negotiate` schema and example.
2 changes: 1 addition & 1 deletion data/event-schemas/examples/m.call.negotiate.yaml
Expand Up @@ -6,7 +6,7 @@
"party_id": "67890",
"call_id": "12345",
"lifetime": 10000,
zecakeh marked this conversation as resolved.
Show resolved Hide resolved
"offer": {
"description": {
"type" : "offer",
"sdp" : "v=0\r\no=- 6584580628695956864 2 IN IP4 127.0.0.1[...]"
}
Expand Down
13 changes: 6 additions & 7 deletions data/event-schemas/schema/m.call.negotiate.yaml
Expand Up @@ -42,15 +42,16 @@ properties:
allOf:
- "$ref": core-event-schema/call_event.yaml
properties:
offer:
description:
type: object
title: Offer
title: Description
description: The session description object
properties:
type:
type: string
enum:
- offer
- answer
description: The type of session description.
sdp:
type: string
Expand All @@ -60,12 +61,10 @@ properties:
- sdp
lifetime:
type: integer
description: The time in milliseconds that the invite is valid for.
Once the invite age exceeds this value, clients should discard it.
They should also no longer show the call as awaiting an answer in the
UI.
description: The time in milliseconds that the negotiation is valid for.
Once the negotiation age exceeds this value, clients should discard it.
required:
- offer
- description
- lifetime
type:
type: string
Expand Down