Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure version in x-changedInMatrixVersion is a string #1562

Merged
merged 2 commits into from Jun 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/internal/newsfragments/1562.clarification
@@ -0,0 +1 @@
Make sure version in x-changedInMatrixVersion is a string.
Expand Up @@ -104,7 +104,7 @@ properties:
by the local homeserver, and is only returned if the event is a state event,
and the client has permission to see the previous content.
x-changedInMatrixVersion:
1.2: |
"1.2": |
Previously, this field was specified at the top level of returned
events rather than in `unsigned` (with the exception of the [`GET
.../notifications`](/client-server-api/#get_matrixclientv3notifications)
Expand Down
2 changes: 1 addition & 1 deletion data/event-schemas/schema/m.call.hangup.yaml
Expand Up @@ -35,7 +35,7 @@ properties:
previous previous versions of the spec, so a missing value should be
treated as `user_hangup`.
x-changedInMatrixVersion:
1.7: |-
"1.7": |-
Additional values were added.
enum:
- ice_timeout
Expand Down
2 changes: 1 addition & 1 deletion data/event-schemas/schema/m.receipt.yaml
Expand Up @@ -2,7 +2,7 @@ type: object
title: Receipt Event
description: Informs the client of new receipts.
x-changedInMatrixVersion:
1.4: |
"1.4": |
Added `m.read.private` receipts to the event's `content`.
allOf:
- $ref: "core-event-schema/event.yaml"
Expand Down
4 changes: 2 additions & 2 deletions data/event-schemas/schema/m.room.encrypted.yaml
Expand Up @@ -42,7 +42,7 @@ properties:
sender_key:
type: string
x-changedInMatrixVersion:
1.3: |-
"1.3": |-
Previously this field was required, however given it offers no additional
security or privacy benefit it has been deprecated for Megolm messages.
See [`m.megolm.v1.aes-sha2`](#mmegolmv1aes-sha2) for more information.
Expand All @@ -57,7 +57,7 @@ properties:
device_id:
type: string
x-changedInMatrixVersion:
1.3: |-
"1.3": |-
Previously this field was required for Megolm messages, however given it
offers no additional security or privacy benefit it has been deprecated
for Megolm messages. See [`m.megolm.v1.aes-sha2`](#mmegolmv1aes-sha2) for
Expand Down
2 changes: 1 addition & 1 deletion data/event-schemas/schema/m.room_key_request.yaml
Expand Up @@ -24,7 +24,7 @@ properties:
sender_key:
type: string
x-changedInMatrixVersion:
1.3: |-
"1.3": |-
Previously this field was required, however given it offers no additional
security or privacy benefit it has been deprecated. See [`m.megolm.v1.aes-sha2`](#mmegolmv1aes-sha2)
for more information.
Expand Down