Fix enum types in JSON schemas #1634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`type: enum` does not exist, as an enum can be of any type. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
KitsuneRal
approved these changes
Sep 12, 2023
Member
|
That looks good, but should we also show |
Contributor
Author
|
Sure we could do that, it should be simple enough. Do you want me to add a commit to this PR or should it be in another PR? |
Member
|
Just add another commit here. |
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
richvdh
approved these changes
Sep 19, 2023
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
lgtm but maybe @KitsuneRal wants another look?
Member
|
Assuming kitsune is happy here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type: enumdoes not exist, as an enum can be of any type.Preview: https://pr1634--matrix-spec-previews.netlify.app