Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec for shared-history room keys (MSC3061) #1655

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add spec for shared-history room keys (MSC3061) #1655

wants to merge 4 commits into from

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Oct 4, 2023 •
edited by github-actions bot

@uhoreg uhoreg requested a review from a team as a code owner October 4, 2023 00:43
@uhoreg uhoreg mentioned this pull request Oct 4, 2023
Merged
@zecakeh zecakeh mentioned this pull request Oct 4, 2023
Merged
poljar
poljar reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we push this to the spec, considering the problems which were subsequently discovered with this MSC3061?

richvdh
richvdh previously requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending a decision about wtf we are doing here

@richvdh
Copy link
Member

richvdh commented Feb 26, 2024

Given this completed FCP, it belongs in the spec. If we want to rip it out the spec again, that will require a new MSC.

@richvdh richvdh requested a review from a team February 26, 2024 14:45
@richvdh
Copy link
Member

richvdh commented Feb 27, 2024

Apparently there are security concerns, specifically around sharing keys for past messages. We'll disclose more details in a few weeks, and then we can decide how best to proceed here.

@richvdh richvdh mentioned this pull request Feb 28, 2024
Open
@uhoreg @Johennes
Remove extra space
4e6cd55 
Co-authored-by: Johannes Marbach <n0-0ne+github@mailbox.org>
turt2live
turt2live reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearing team review request while awaiting security impact

@Michael-Hollister Michael-Hollister mentioned this pull request May 7, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poljar poljar poljar left review comments

@Johennes Johennes Johennes left review comments

@turt2live turt2live turt2live left review comments

@richvdh richvdh richvdh left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@uhoreg @richvdh @poljar @Johennes @turt2live