Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that threads can be created based on replies #1687

Merged

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented Dec 1, 2023

Signed-off-by: Andy Balaam <andy.balaam@matrix.org>
Signed-off-by: Andy Balaam <andy.balaam@matrix.org>
@andybalaam andybalaam force-pushed the andybalaam/threads-can-be-off-replies branch from 5540143 to 7e5d2a7 Compare December 1, 2023 09:39
@andybalaam andybalaam marked this pull request as ready for review December 1, 2023 09:40
@andybalaam andybalaam requested a review from a team as a code owner December 1, 2023 09:40
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm!

@andybalaam
Copy link
Contributor Author

@richvdh does this need approval from someone else before merging?

@richvdh richvdh merged commit a843cad into matrix-org:main Dec 11, 2023
12 checks passed
@richvdh
Copy link
Member

richvdh commented Dec 11, 2023

no, thanks for the reminder 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec says you can't create a thread from a reply, but popular clients and servers say you can
2 participants