Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a POST request in Federation request signing example #1721

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

reivilibre
Copy link
Contributor

@reivilibre reivilibre commented Feb 1, 2024

Otherwise the GET request having a body is confusing, since it is not valid HTTP

Preview: https://pr1721--matrix-spec-previews.netlify.app

Otherwise the GET request having a body is confusing, since it is not valid HTTP
@reivilibre reivilibre requested a review from a team as a code owner February 1, 2024 13:46
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good catch

@uhoreg uhoreg merged commit 2cb70e6 into matrix-org:main Feb 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants