Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi-stream VoIP #1735
Add support for multi-stream VoIP #1735
Changes from 9 commits
47db8f2
fcd18bb
3cfade3
ffac074
4e41985
83b3c67
8ce2b94
ef9546d
d6d3c50
671685e
02706b5
b0cfa29
f8ff581
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richvdh said:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will
probably needs to be changed to aMUST
, like in other places in the spec.addTrack
note is a bit of help for client implementation. For context it refers toRTCPeerConnection: addTrack()
. It's a method that takes a track and any number of streams. If there is no stream provided, it creates a streamless track, which is why the method should be called with a track and a stream. In my opinion the note could be removed.sdp_stream_metadata
, it is about streams, and it just happens that it is the only paragraph left that doesn't mention the field. It could be placed at the top or bottom of the section if you prefer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will
toMUST
(or, maybe more readably,should
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this belongs in
core-event-schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Since it doesn't seem to belong directly in
schemas
either, because it only contains full event schemas, I took the liberty to create acomponents
directory (named like this for similarity with the property that includes reusable bits in the OpenAPI spec)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied